-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modern-cqut-thesis:0.1.0 #1437
modern-cqut-thesis:0.1.0 #1437
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your package. I left a few comments, feel free to ask me if you need more explanations on how to fix these issues.
Also, just so that you know for next time, you don't have to close and re-open pull requests if you make mistakes. It is fine to have a dirty commit history, they will be squashed into a single one upon merge.
// 这个是当前目录下导入 lib 编译 | ||
#import "../lib.typ": * | ||
|
||
// 这个是 ~/preview/CQUT-Thesis-Typst:0.1.0/目录下导入 lib 编译,可用 install 脚本使用 | ||
// #import "@preview/CQUT-Thesis-Typst:0.1.0": documentclass, indent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your template should use the "absolute" import by default.
// 这个是当前目录下导入 lib 编译 | |
#import "../lib.typ": * | |
// 这个是 ~/preview/CQUT-Thesis-Typst:0.1.0/目录下导入 lib 编译,可用 install 脚本使用 | |
// #import "@preview/CQUT-Thesis-Typst:0.1.0": documentclass, indent | |
#import "@preview/cqut-thesis-typst:0.1.0": documentclass, indent |
This way the template works out of the box, as soon as a new project is created from it.
@@ -0,0 +1,205 @@ | |||
// 这个是当前目录下导入 lib 编译 | |||
#import "../lib.typ": * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for this import.
@@ -0,0 +1,16 @@ | |||
[package] | |||
name = "cqut-thesis-typst" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless this template is official and endorsed by the university staff, you should change the name of the package to something more unique (you can add a distinctive adjective for instance). If someone else was to submit another non-official alternative to this package, they should not be disadvantaged because you already took the "canonical" name.
If this template is an official one, please tell me by writing an email to [email protected]
stating so, using your academic email.
And regardless of whether the package is official or not, its name should not include typst
: it is obvious that this is a Typst package, so the information is just redundant.
Can you please rename it to conform to our guidelines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, the new name is fine.
bodyfmt: x => x, | ||
separator: [#h(0.1em)\ ], | ||
base: "heading", | ||
base_level: none, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be more coherent with the rest of the package (and with Typst conventions in general) it would be nice to rename this to base-level
.
@@ -0,0 +1,165 @@ | |||
#import "@preview/ctheorems:1.1.2": * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ctheorems 1.1.2 reports deprecation warnings with Typst 0.12.0. It would be nice if you could update to 1.1.3, which should work better.
9900a70
to
2157cee
Compare
But I found the page numbering have some problems... so I roolback the package named "anti-matter" from 0.1.1 to 0.0.2 again... |
4693d51
to
c059119
Compare
If you want to fix the issue with |
b31cf8c
to
7ca0b20
Compare
Thanks for the advice! I really fell into my original mistake and didn't think of this idea. |
update coments update anti-matter with the original codes now is just import * ,this does not elegant... Update thesis.typ 退回 anti-matter 到0.0.2
5aafbf8
to
c84f94b
Compare
Did that fix the numbering issue? |
Yes I have fixed the numbering issue. It works fine now. |
Great, I'll merge this PR then. Thanks again for the package :) |
I select the template from Typst(app) to check up. The only problem is the fonts, should I upload(commit) the required fonts?
|
Fonts are usually not committed to this repository. What we recommend instead is to have a guide on how to install/import them in the README of the package (or in a comment in the template file), and let each user follow these steps. |
Submission Type:
Description:
This package provides a Typst template for Chongqing University of Technology (CQUT) thesis. It aims to help students quickly generate PDF format graduation theses that comply with university requirements. Key features include:
Users can easily customize their thesis by modifying the
thesis.typ
file. The template is designed to be extensible and can be adapted for various CQUT academic document needs.This submission includes all necessary files, documentation, and license information as per the package submission guidelines.
I have read and followed the submission guidelines, particularly I have:
typst.toml
file with all required keysREADME.md
with documentation for my package